[WIP] OCPBUGS-26498: Remove lease.Extend from performIngressConditionRemoval#590
[WIP] OCPBUGS-26498: Remove lease.Extend from performIngressConditionRemoval#590gcs278 wants to merge 1 commit intoopenshift:masterfrom
Conversation
Since performIngressConditionUpdate already extends the lease, we should not extend the lease in performIngressConditionRemoval. The lease gets over extended because the UpgradeValidation plugin and the Status plugin both attempt to update route status in two separate lease work items and both are extending the lease when there is no work to be done. In a scenario where the Status plugin needs to admit a route, but the UpgradeValidation has no change to UnservableInFutureVersions condition, the UpgradeValidation lease work item will unnecessarily extend the lease, leading to an extra delay in the Status plugin admitted the route. Also add a TODO item to document current limitations of doing multiple status updates in the same route reconcile loop for future developers.
openshift-ci-robot
added
jira/severity-moderate
|
@gcs278: This pull request references Jira Issue OCPBUGS-26498, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gcs278
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing in favor of #587 |
|
@gcs278: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gcs278: This pull request references Jira Issue OCPBUGS-26498. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2 participants
Since performIngressConditionUpdate already extends the lease, we should not extend the lease in performIngressConditionRemoval. The lease gets over extended because the UpgradeValidation plugin and the Status plugin both attempt to update route status in two separate lease work items and both are extending the lease when there is no work to be done.
In a scenario where the Status plugin needs to admit a route, but the UpgradeValidation has no change to UnservableInFutureVersions condition, the UpgradeValidation lease work item will unnecessarily extend the lease, leading to an extra delay in the Status plugin admitted the route.
Also add a TODO item to document current limitations of doing multiple status updates in the same route reconcile loop for future developers.